-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy current develop to aws to allow faster testing #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the root cause of the pre-commit problem and the fix is here: pre-commit/action#210 (comment)
Your change will work however it seems much more verbose than the original setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR Checklist:
[ ] Describe and explain your intentions for this change
[ ] Setup pre-commit and run the validators (info in README.md)
Per slack comment: https://sagebionetworks.slack.com/archives/C07HLTBS5D2/p1729016982033769
Also fixed workflow related to: https://sagebionetworks.jira.com/browse/FDS-2514
The initial error message in the workflow: